Discussion:
Review request backport 8210386
Johan Vos
2018-10-29 16:39:18 UTC
Permalink
Hi Kevin,

Please review the backport of 8210386 (Marlin fixes) into 11-dev (target
11.0.1)
http://cr.openjdk.java.net/~jvos/8210386/webrev.00/

- Johan
Kevin Rushforth
2018-10-29 16:55:18 UTC
Permalink
The newly added test, which was pushed to jfx-dev as part of the fix for
12, is missing from the webrev:

tests/system/src/test/java/test/com/sun/marlin/ScaleClipTest.java

The rest looks OK.

-- Kevin
Post by Johan Vos
Hi Kevin,
Please review the backport of 8210386 (Marlin fixes) into 11-dev (target
11.0.1)
http://cr.openjdk.java.net/~jvos/8210386/webrev.00/
- Johan
Johan Vos
2018-10-29 18:27:31 UTC
Permalink
new webrev including test:
http://cr.openjdk.java.net/~jvos/8210386/webrev.01/
<http://cr.openjdk.java.net/~jvos/8210386/webrev.00/>
Post by Kevin Rushforth
The newly added test, which was pushed to jfx-dev as part of the fix for
tests/system/src/test/java/test/com/sun/marlin/ScaleClipTest.java
The rest looks OK.
-- Kevin
Post by Johan Vos
Hi Kevin,
Please review the backport of 8210386 (Marlin fixes) into 11-dev (target
11.0.1)
http://cr.openjdk.java.net/~jvos/8210386/webrev.00/
- Johan
Kevin Rushforth
2018-10-29 18:35:28 UTC
Permalink
Looks good. Approved for pushing to 11-dev.

-- Kevin
Post by Johan Vos
http://cr.openjdk.java.net/~jvos/8210386/webrev.01/
<http://cr.openjdk.java.net/%7Ejvos/8210386/webrev.00/>
On Mon, Oct 29, 2018 at 5:55 PM Kevin Rushforth
The newly added test, which was pushed to jfx-dev as part of the fix for
tests/system/src/test/java/test/com/sun/marlin/ScaleClipTest.java
The rest looks OK.
-- Kevin
Post by Johan Vos
Hi Kevin,
Please review the backport of 8210386 (Marlin fixes) into 11-dev
(target
Post by Johan Vos
11.0.1)
http://cr.openjdk.java.net/~jvos/8210386/webrev.00/
<http://cr.openjdk.java.net/%7Ejvos/8210386/webrev.00/>
Post by Johan Vos
- Johan
Laurent Bourgès
2018-10-30 06:19:37 UTC
Permalink
Thank you,

Laurent
Post by Kevin Rushforth
Looks good. Approved for pushing to 11-dev.
-- Kevin
Post by Johan Vos
http://cr.openjdk.java.net/~jvos/8210386/webrev.01/
<http://cr.openjdk.java.net/%7Ejvos/8210386/webrev.00/>
On Mon, Oct 29, 2018 at 5:55 PM Kevin Rushforth
The newly added test, which was pushed to jfx-dev as part of the fix for
tests/system/src/test/java/test/com/sun/marlin/ScaleClipTest.java
The rest looks OK.
-- Kevin
Post by Johan Vos
Hi Kevin,
Please review the backport of 8210386 (Marlin fixes) into 11-dev
(target
Post by Johan Vos
11.0.1)
http://cr.openjdk.java.net/~jvos/8210386/webrev.00/
<http://cr.openjdk.java.net/%7Ejvos/8210386/webrev.00/>
Post by Johan Vos
- Johan
Loading...